I suspect I will make more enemies with this post than friends, but meh lol
156s clinch it for me overall. 158s may be faster, more modern, are a good deal quieter and look/feel surprisingly modern with the right refurb, but for me personally, the 156s have engrained themselves in my psyche for numerous reasons: I have done significantly more miles in them, have always preferred the liveries the Scottish-based ones have carried over the years, the enthusiast in me prefers the 156s' engine noise, they are warm (a boon in the bitterly cold winter mornings during the period I regularly used
1Y20 to commute to college in Glasgow), the interior of the Barbie-liveried examples I found to be rather comfortable besides, they are bullet-proof reliability-wise (never had one fail on me) and I've always preferred their looks to that of the 158s (don't ask me why, I can't explain it either. It's no doubt tied in with the point about the liveries). On top of all that, the sound of several-dozen 156s idling away to themselves at Glasgow Central High Level is one of those sounds that takes me right back to my childhood, when the place was near enough swarming with them.
Barring the SPT Carmine/Cream & ScotRail (National Express) liveries, a Barbie-liveried 156 will be how I personally best remember them (attached image is my own) after they finally bow out of service here.
(Abellio ScotRail 156493 calling at Singer with 1Y20 from Oban to Glasgow Queen St High Level. This is the only DMU-worked service to call here - 29/05/17)